Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test aliases during a partial join resync #537

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Test aliases during a partial join resync #537

merged 3 commits into from
Nov 2, 2022

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Oct 25, 2022 •
edited
Loading

@DMRobertson DMRobertson requested review from a team as code owners October 25, 2022 16:02
@DMRobertson DMRobertson mentioned this pull request Oct 25, 2022
Merged
@DMRobertson
Copy link
Contributor Author

Going to wait for the Synapse change to land before merging this.

@DMRobertson
Copy link
Contributor Author

I've added in another test case. Sean, would you mind taking a quick look?

@DMRobertson DMRobertson requested a review from squahtx November 1, 2022 15:05
squahtx
squahtx approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional test case lgtm

@DMRobertson
Copy link
Contributor Author

Cheers!

@DMRobertson DMRobertson merged commit ec35877 into main Nov 2, 2022
@DMRobertson DMRobertson deleted the dmr/faster-joins/aliases branch November 2, 2022 17:19
@squahtx squahtx mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

@squahtx squahtx squahtx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DMRobertson @squahtx @erikjohnston